Anim speed #228
Merged
Anim speed #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsherGlick
requested changes
Nov 15, 2023
xml_converter/intigration_tests/inputs/xml_animation_speed/xml_file.xml
Outdated
Show resolved
Hide resolved
AsherGlick
requested changes
Nov 25, 2023
| name="animation_speed", | ||
| xml_input_paths=["./inputs/xml_animation_speed"], | ||
| expected_output_xml_path="./expected_outputs/xml_animation_speed", | ||
| ), |
There was a problem hiding this comment.
Where are the proto testcases?
There was a problem hiding this comment.
As mentioned in the top comment, the proto will be changed by #151. I didn't want to add an incorrect proto
There was a problem hiding this comment.
Why not just change the proto here? Now seems like as good of a time as any to avoid it being forgotten.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Full Diff
--- xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._old 2023-12-03 21:09:20.738595640 +0000
+++ xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._new 2023-12-03 21:09:20.746595627 +0000
@@ -0,0 +1,35 @@
+category {
+ name: "My Category"
+ trail {
+ }
+ trail {
+ }
+ trail {
+ animation_speed: 3.14
+ }
+ trail {
+ animation_speed: 123.456
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ animation_speed: 3.14
+ }
+ trail {
+ animation_speed: 123.456
+ }
+ trail {
+ animation_speed: -3.14
+ }
+ trail {
+ animation_speed: -123.456
+ }
+ trail {
+ animation_speed: -3.14
+ }
+ trail {
+ animation_speed: -123.456
+ }
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._old 2023-12-03 21:10:27.535470994 +0000
+++ xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._new 2023-12-03 21:10:27.543471044 +0000
@@ -0,0 +1,35 @@
+category {
+ name: "My Category"
+ trail {
+ }
+ trail {
+ }
+ trail {
+ animation_speed: 3.14
+ }
+ trail {
+ animation_speed: 123.456
+ }
+ trail {
+ }
+ trail {
+ }
+ trail {
+ animation_speed: 3.14
+ }
+ trail {
+ animation_speed: 123.456
+ }
+ trail {
+ animation_speed: -3.14
+ }
+ trail {
+ animation_speed: -123.456
+ }
+ trail {
+ animation_speed: -3.14
+ }
+ trail {
+ animation_speed: -123.456
+ }
+}
There was a problem hiding this comment.
Full Diff
--- xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._old 2023-12-04 03:28:00.138085994 +0000
+++ xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._new 2023-12-04 03:28:00.146085948 +0000
@@ -0,0 +1,179 @@
+category {
+ name: "My Category"
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -123.456
+ }
+}
|
As discussed, I am going to change the default to 0 |
There was a problem hiding this comment.
Full Diff
--- xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._old 2023-12-05 02:08:49.831166946 +0000
+++ xml_converter/intigration_tests/expected_outputs/proto_animation_speed/markers.bin.textproto._new 2023-12-05 02:08:49.839166935 +0000
@@ -0,0 +1,181 @@
+category {
+ name: "My Category"
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 1
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 1
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: 123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -123.456
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -3.14
+ }
+ trail {
+ map_id: 50
+ trail_data {
+ points_x: 1
+ points_x: 2
+ points_x: 3
+ points_y: 4
+ points_y: 5
+ points_y: 6
+ points_z: 7
+ points_z: 8
+ points_z: 9
+ }
+ animation_speed: -123.456
+ }
+}
AsherGlick
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protobin is not added here as it will be changed by #151